Repository navigation
Conversation
Replay never sends the close again, so a close left in the background was lost when the process stopped. The proto also asks lang to publish for an activation that only resolves an owner.
…vity-closes # Conflicts: # crates/streams/src/lib.rs # crates/streams/src/workflow.rs # crates/streams/tests/workflow_output.rs
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR closes owner Activity streams in the Workflow publish call.
PublishWorkflowTaskRequestgetsresolved_owner_activities, the Activities of the activation'sResolveActivityjobs that lang scheduled withSTREAM_OWNER_HEADER. After the records land, the service closes each topic the Activity wrote, in the background. A completed Activity closes with an empty result, and a failed or cancelled one with the failure the server gave.ShutdownWorkerwaits for the closes.Reviewed in moetemp/sdk-rust#173, where Core closed the streams at the resolution.
Why?
Lang sets the owner header, so it knows which resolutions end an owner's streams. The close runs before Core takes the completion. A rerun of a refused task closes again, and the store answers with the first close.
How did you test it?
Link to a test plan if any -