Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets the service
CreateStreamandAppendRecordstake a Workflow's calls from outside Workflow code, as S108's Local Activities make them.CreateStreamRequest.owner(6) names the owning run. With it, the Stream is created Workflow-owned and keeps the safety TTL, which needs thesafety_ttlcapability.withdraw_runonCreateStreamandAppendRecordsnow reaches the Store, so a retry run's first call to a Stream withdraws the previous run, which needs therun_fencecapability. The create'sSupersededfacts have no epoch, so a Reader withdraws only that run. The proto getsclose_with_run(7) andref(8) too, the server's text, which only the native Store reads. A deduplicated append still answers the stored batch's offsets.Why?
Decision S108. Workflow publish, create and close become one Local Activity each, on the Activity writer path. The run buffer used to send
withdraw_run, and that path dropped it.How did you test it?
cargo fmt --all -- --check,cargo clippy --workspace --tests -- -D warnings(also with--no-default-features --features tls-aws-lc), andSTREAMS_REQUIRE=redis cargo test --workspaceon standalone Redis, cluster Redis and memory. A new service test runs a previous run's Local Activity append, then a retry run's create and append withwithdraw_run, and a resend of that append. It checks theSupersededitem withdraws only the previous run, and that the resend keeps its offsets.