Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the Stream service WIT to the crate with docs that fit 100 columns, and removes the buffered
Publishpath of writers.crates/streams/nexus/stream-service.witis now the source copy, taken from the sdk-python copy at9f9e3f017. Each SDK copies it. The eleven@nexus.doclines over 100 columns are shorter, with the same meaning. Two use the continuation form that nexgen documents (/// @nexus.docthen/// "<text>"). The header points at the proto. A new test keeps every line at most 100 columns and checks the five operations.Removed from the extension:
PublishwithPublishRequestandPublishResponse;FlushWriterwithFlushWriterRequestandFlushWriterResponse;OpenWriterRequest.batch_interval(4) andmax_buffered_records(7), nowreservedby number and name;stream_buffer_fullreason (Reason::BufferFull) and thestream_buffer_fullmetric.OpenWriterRequest.max_batch_size(5) andmax_retry_duration(6) stay, sinceWriteRecordssplits by the first and retries by the second.CloseWriterwaits for a write in flight, then drops the writer and answers its last offset, or the error it failed with.CloseWritersdrops every writer.Why?
Lang no longer uses the interval batching path. Python publishes with
WriteRecords, andBufferedPublisherbuffers in Python. The WIT docs had lines over the 100-column limit.How did you test it?
cargo fmt --all -- --check,cargo clippy --workspace --tests -- -D warnings(also with--no-default-features --features tls-aws-lc), andSTREAMS_REQUIRE=redis cargo test --workspaceon standalone Redis, a 3-primary Redis cluster and the memory Store.The writer tests now use
WriteRecordsonly, for order, batch split, a failed write, an Activity retry, close, reopen andCloseWriters. A new test checks thatPublishandFlushWriterare unknown methods.