Repository navigation
Conversation
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR removes the reader idle timeout from the Stream service.
ReadRecordsRequest.idle_timeout(9) andSTREAM_RECORD_KIND_IDLE(4) are nowreservedinstream_service.proto, by number and by name.read_recordsno longer computes an idle deadline or makes an Idle Record. A read ends with the Records it found, the close Record, or an empty page afterwait. The test of the Idle Record now checks that a quiet read ends empty after itswait, withnext_offsetat the place to resume from.Why?
Decisions S45 and S75. A Reader that wants to stop after a quiet period sets its own timer and resumes from
next_offset. A later opt-in idle notification can be added without a break.How did you test it?
cargo fmt --all -- --check,cargo clippy --workspace --tests -- -D warnings, andSTREAMS_REQUIRE=redis cargo test --workspaceon standalone Redis, a 3-primary Redis cluster and the memory Store.