Repository navigation
Conversation
A Store that can't fence, flag, close or wait for replicas must refuse the calls that need them by name, not give weaker guarantees in silence. The memory Store now refuses durable_writes for that reason.
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR splits the
Storetrait into the required log calls and capability calls. The log calls arecreate, the atomic batchappend,readwith the Stream's state, andwait_after.closeandwait_replicasbecome optional calls that refuse by default.capabilities()has no default, so a wrapper Store must say what it forwards. The capabilities areproducer_fence,withdrawal,run_fence,close,replica_waitandsafety_ttl, one per rule that the Lua scripts keep atomically. The service and the Workflow path check them before any write. A missing one fails with UNIMPLEMENTED and the reasonstream_unsupported, and the message names the capability.RedisStoredeclares all of them.MemoryStoredeclares all butreplica_wait, sodurable_writeson memory now fails by name.MemoryStreamExtension::from_config_bytesnow readsdurable_writes.Why?
A Store with fewer guarantees must refuse a call it can't keep. It must not give a weaker answer in silence. This is the split of the 2026-10-16 capability design fitted to v3, with no reader-side fallbacks yet.
How did you test it?
STREAMS_REQUIRE=redis cargo test -p temporalio-streams, on standalone Redis, cluster Redis and the memory Store. New tests mask one capability at a time on a memory Store wrapper. Each needed call is refused by name with nothing written, and the Stream stays as it was. A test also checks that every Store and wrapper reports its capabilities, the Redis durable view included.