Repository navigation
Conversation
A Reader that gets a Workflow's ref can find the Workflow with no parse of the id. The Store still keys on the id alone, so a ref with or without the owner reaches the same Stream.
This was referenced Oct 21, 2026
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds two optional fields to
StreamRef:workflow_id = 2andfirst_execution_run_id = 3. A Workflow's ref sets them. A standalone, client or Activity ref leaves them empty. The Store keys onidonly and never reads them, so a write or a read never fails because they are missing or disagree with the id. The crate builds aStreamRefonly in theCreateStreamanswer, which has no owner to give, so it leaves them empty there.Why?
DECISIONS S30. A Reader that gets a Workflow's ref can find the Workflow with no parse of the id.
How did you test it?
STREAMS_REQUIRE=redis cargo test -p temporalio-streams, on standalone Redis, cluster Redis and the memory Store. A new test writes through a ref with the owner fields, one without them and one with fields that don't match, and reads the same Stream through both. The Workflow tests now buffer calls with full Workflow refs.