Repository navigation
Conversation
The harness reads a family of Topics, such as every tool's, with no list of names. topics stays an exact match, as in Workflow Streams, so the prefixes are a field of their own.
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
repeated string topic_prefixes = 10toReadRecordsRequest. A read gives a Record when its Topic is intopicsor starts with one of the prefixes.topicsstays an exact match, aSupersededitem still passes every filter, and the scan cap per page still applies.Why?
The harness port reads a family of Topics, such as every tool's Topic, and doesn't know their names in advance (DECISIONS S29).
How did you test it?
STREAMS_REQUIRE=redis cargo test -p temporalio-streams, on standalone and cluster Redis, with a unit test of the filter and a read test with both fields.