Repository navigation
Conversation
Activities and clients reach the Store through the bridge's generic async call, by operation name and proto bytes. A read is the long poll of the proposal, with the create wait, the idle end and the Retention check.
A Tombstone gets no more Records, so a Reader that waited on it never ended. A Topic filter with no match also scanned the whole log in one page.
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
RedisStreamExtension, theWorkerExtensionthat servesCreateStream,AppendRecords,CloseStream,ReadRecordsandDescribeStreamthroughcall_async, by operation name and proto bytes.ReadRecordsis a long poll with an inclusivefrom_offset,create_wait,idle_timeoutand the Retention gap check. Every read ends with the close Record or an Idle Record, a read of an expired open Stream fails at once, and aSupersededitem passes every Topic filter. Errors go to lang as anExtensionErrorwith the gRPC code and a reason token.Why?
Activities and clients reach the Store through the bridge's generic call, so the bridge has no stream code. The extension connects on first use, so a bridge can build it with no runtime.
How did you test it?
STREAMS_REQUIRE=redis cargo test -p temporalio-streams --test service, on standalone and cluster Redis.