Repository navigation
Conversation
The v3 design serves the five Stream service operations on Redis, so the crate starts again from the API proposal's protos. The shared vectors pin the ids, keys, offsets, epochs and the withdrawal rule for every SDK.
Core gives the previous completed task with attempt 0 when it no longer has the attempt, and the rule then missed the failed attempts at c. The buffer call also gets chain_continues, so lang can stop the auto close of a run whose Chain goes on.
This was referenced Oct 21, 2026
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #41, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR starts the v3
temporalio-streamscrate from the Brook API proposal. It adds the Stream service proto of the proposal and the crate's own extension call protos, built with prost against sdk-rustc4. It also adds the rules every SDK must share: Stream ids, Producer ids, the Redis keys and meta fields, offsets (ms << 20 | seq), epoch keys and the withdrawal rule of aSupersededitem.Why?
The v3 design serves five Stream service operations on Redis, so little of the v2 store layer fits. The shared vectors in
testdata/let the Python, TypeScript and .NET lanes check their id builders andwithdraws()against the same files.gen_vectors.pywrites them from a second implementation.How did you test it?
cargo test --workspacechecks the Rust rules against the vectors, including the Appendix E withdrawal examples.