Repository navigation
Conversation
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR moves Bridge's Nexus calls out of Core. The notifier client attaches a stream operation's caller through
AttachStreamCallbackby method path, with its callback URL, headers, token and start time. The newexecute_sync_nexus_operationcallsExecuteSyncNexusOperationby method path, with the namespace header. The live notifier tests attach their caller through the service'sAttachCallerand detach it at the end, as Bridge's Core did.The raw path skips the typed client's payload size check of
ExecuteSyncNexusOperationRequest.input. The server still checks sizes.Reviewed in moetemp/sdk-rust#176 and moetemp/sdk-rust#177.
Why?
sdk-rust lists neither RPC, so the crate calls them through
Connection::raw_unaryand keeps their messages in its own API copy.How did you test it?
Link to a test plan if any -