Repository navigation
Conversation
This was referenced Oct 27, 2026
moetemp
force-pushed
the
moe/brook/review/streams-k1-protos
branch
from
October 27, 2026 07:35
adac538 to
4078d83
Compare
moetemp
force-pushed
the
moe/brook/review/c1-workflow-task
branch
from
October 27, 2026 08:17
9030f04 to
5dbc91c
Compare
moetemp
force-pushed
the
moe/brook/review/streams-k1-protos
branch
4 times, most recently
from
October 28, 2026 08:55
6b5105d to
b906e6f
Compare
moetemp
force-pushed
the
moe/brook/review/c1-workflow-task
branch
from
October 28, 2026 08:55
5dbc91c to
6eace0b
Compare
The crate is the Stream runtime that the SDKs link. It is experimental. The Stream protos are a copy of the API proposal, and they import this repo's API protos.
moetemp
force-pushed
the
moe/brook/review/streams-k1-protos
branch
from
October 29, 2026 04:06
b906e6f to
088e221
Compare
The CHANGELOG repeated part of c1's entry. Lang reads the reason from the error details, not from the token. OpenWriterRequest reserves the numbers of its removed fields.
The failure gives the close status. A zero sequence now takes the next batch number of the epoch.
Owner
Author
|
Upstreamed as temporalio#1733, on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
crates/streams, the experimental cratetemporalio-streams, with the Stream protos.temporalio/api#895). They import this repo's API protos, which the build script reads from the descriptor set oftemporalio-protos. So the crate vendors no other proto, andcargo package -p temporalio-streamspasses.runtime.protohas the runtime's own messages. The Redis config moved to the Redis crate.StreamErrorDetailsin its details.Reason::protogives each reason'sStreamErrorReasoncase.Reason::OffsetisOUT_OF_RANGE, since a read from that offset works again once the Stream has Records up to it.crates/sdk-core/CHANGELOG.mdnotes the crate. Core itself gets no Stream code.It sits on C1 (
temporalio/sdk-rust#1703), but no layer of this stack needs C1 to build. Review lane is the Core team, and the proto reviewers for the protos.Part of the Brook review series.
Why?
The SDK team asked for the Stream runtime in its own crate, with the shared part in this repo. This stack moves the shared part of
moetemp/sdk-streams#43to#52here, in the same order and with the same K numbers. The Redis Store is intemporal-community/sdk-streams#1to#3(R1 to R3).The protos are the contract with every SDK, so they're first and alone.
How did you test it?
cargo fmt,cargo clippy -- -D warnings(with and without features),cargo test -p temporalio-streams --all-features,cargo docandcargo package -p temporalio-streamspass at this commit.