Skip to content

[Brook] Added a Workflow Task interceptor that runs around each completion. #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moetemp wants to merge 2 commits into from
Closed

[Brook] Added a Workflow Task interceptor that runs around each completion. #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
660346e
Added a workflow task interceptor that runs around each completion.
moetemp Oct 21, 2026
f7a0087
Bounded the interceptor hooks and measured the deadline from receipt.
moetemp Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/sdk-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ relevant information.

## Unreleased

### Added
* A worker can take a `WorkerExtension` whose `WorkflowTaskInterceptor` runs before and after
each workflow task completion Core sends, including the local activity heartbeat completion
and the completion of output buffered before an eviction. An error from `before_complete`, or
a hook that misses the task's deadline, fails the workflow task. Core waits at most five
seconds on `after_complete`. The replay worker never calls the hooks.

### Security
* Ephemeral server downloads now use `zip` 9.0 for ZIP extraction, replacing the 8.x dependency
[yanked upstream for security issues](https://github.com/zip-rs/zip2/issues/1075#issuecomment-6209381974).
Expand Down
1 change: 1 addition & 0 deletions crates/sdk-core/src/core_tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ mod replay_flag;
mod updates;
mod workers;
mod workflow_cancels;
mod workflow_task_interceptor;
mod workflow_tasks;

use crate::{
Expand Down
Loading
Loading