Repository navigation
Conversation
moetemp
changed the title
This was referenced Oct 17, 2026
Vendored protos are copied verbatim, so the tests checked the copy and not the server.
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR vendors two generic Nexus callback fields from api
moe/bridge/v2/dr40-sdk-streams(2d204ff9):Callback.NexusHandler.progress_operation = 5andOnCompleteRequest.receiver_state = 4. The proto and OpenAPI lines match the api commit byte for byte. Core reads neither field. sdk-streams carries the rest of the Nexus progress API in its own new files. Stacked on #196.Why?
Both fields are new on upstream messages, so the crate can't carry a second copy. sdk-python's client sets
progress_operationon start requests that Core decodes, and prost drops unknown fields. sdk-python's follower readsreceiver_statein its OnComplete handler, and its protos come from Core's copy. This is Bridge's sdk-rust pin.How did you test it?
Link to a test plan if any -
Ran the lib suites and the full integ suite on this branch.