Repository navigation
Conversation
A package can hold private submodules, such as the Streams API, under `temporalio.common`. The code and the import path stay the same.
This was referenced Oct 25, 2026
Owner
Author
|
Closing this. The Streams code now lives in its own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR renames
temporalio/common.pytotemporalio/common/__init__.py.It's a pure
git mv. The import path staystemporalio.common.Depends on nothing.
Part of the Brook review series.
Why?
A package can hold private submodules, and the Streams PRs put their code under
temporalio/common/_streams/. The rename doesn't need Streams, so it can merge first and alone. Users see no change, so there's no changelog fragment.Checklist
poe lint,poe gen-docsand the common and converter tests.