Repository navigation
Conversation
Workflow code runs in the sandbox, so it can't run the payload codec or call native code. Workflow code gives values to send_to_plugins, and the Worker passes them to the plugin hook outside the sandbox before it completes the Activation. Values from replay are dropped unless the caller asks for them.
A cancel from the hook skipped the completion, so the Activation never completed.
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
Plugin.on_workflow_activation_complete(input)andworkflow.send_to_plugins(value, during_replay=False). Workflow code, or a plugin's Workflow interceptor, gives values tosend_to_plugins. After each successful Activation, the Worker encodes the completion, then calls the hook outside the sandbox with that Activation's values and the Workflow's data converter, then completes the Activation. An exception from the hook fails the Workflow Task. A value given during replay is dropped unlessduring_replay=True. TheReplayernever calls the hook.Why?
Workflow code runs in the sandbox, so it can't run the payload codec or call native code. A plugin needs a point after the Activation and before Core gets the completion. TypeScript has this as a sink with
callDuringReplay.How did you test it?
pytest tests/worker/test_activation_complete_hook.py. It covers the sandboxed and the unsandboxed runner, a cache miss replay, a hook that fails the task, and theReplayer.