Repository navigation
Conversation
Lang code must reach the extension that Core calls, in the same native library. A call by method name with encoded input keeps the bridge free of code for one extension. A failed call raises ExtensionError with the gRPC code and details.
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
WorkerExtension.call(method, input)andawait WorkerExtension.call_async(method, input). They reach the extension'scallandcall_asyncin Core'sWorkerExtensiontrait. A failed call raisestemporalio.worker.ExtensionErrorwith the gRPCcode, themessageand the encodeddetails.Why?
Lang code must reach the same extension that Core calls, and that extension is in the same native library. A call with a method name and encoded input keeps the bridge free of code for one extension. Workflow code uses the synchronous call at the end of an Activation, and Activities and clients use the async one.
How did you test it?
pytest tests/worker/test_extension.py, with the debug-only test extension.