Repository navigation
Conversation
Core calls a WorkerExtension around each Workflow Task, and only native code can build one. So the bridge builds an extension by its name, and the Worker passes it to Core. The Core pin moves to the Brook v3 c4 head, which has the trait.
Lane C's review fixes moved c4. The crate pins the same sdk-rust commit, and the two must match.
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds a
WorkerExtensionand a Workerextensionoption. The Worker passes the extension to Core'sWorkerConfig.extension. The bridge builds an extension from a name and encoded config. Only the extensions that the bridge build links are known. Debug builds link a smalltemporalio-testextension for the SDK's own tests, and release builds leave it out.The
sdk-corepin moves to the Brook v3 Core head (moe/brook/v3/c4-local-activity-workflow-task), which has theWorkerExtensiontrait andActivityTask.Start.workflow_task.Why?
Core calls a
WorkflowTaskInterceptoraround each Workflow Task completion, and only native code can give Core one. Python options can't carry a Rust object, so the bridge builds it by name and the option carries the bridge's handle. The extension must run on the client's runtime, so the Worker checks that.How did you test it?
pytest tests/worker/test_extension.py. The tests run a Workflow with an extension that lets each task complete, and one whosebefore_completefails the task.