Repository navigation
Conversation
2 of 3 tasks
The notifier ops left the system Nexus service, so OnProgressRequest isn't generated anymore. The completion test still covers the system payload path.
OnProgressRequest moved to progress_pb2 with the crate's Nexus API copy. Only the notifier ops left.
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets a client pass
NexusHandlerCallbacks to a standalone Nexus operation, so the server calls a Worker's operation with the completion and the progress. It generates the notification service bindings and visits their payloads.Why?
The Worker follower takes these calls with no Workflow.
How did you test it?
Link to a test plan if any -