Repository navigation
Conversation
2 of 3 tasks
# Conflicts: # temporalio/contrib/streams/_handles.py # tests/contrib/streams/test_unsupported_owners.py
An Activity that owns a stream picks its own or its Workflow's stream with it. A Workflow writes only its own.
# Conflicts: # temporalio/contrib/streams/_handles.py # temporalio/contrib/streams/_local_activity.py
# Conflicts: # temporalio/contrib/streams/_handles.py
This layer writes the attempt's start above the Temporal attempt, so the test reads both attempts from the records.
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets a standalone Activity own a stream.
activity_handle()gives it its own stream, an Activity writes an attempt built from the attempt's start time, anddelete_activity_streamsremoves the streams of an Activity id.Why?
A standalone Activity has no Workflow stream to write to, and a reset sets its Temporal attempt back to one, so the attempt alone can't order its writes.
How did you test it?
Link to a test plan if any -