Repository navigation
Conversation
This was referenced Oct 18, 2026
A reader that wants fewer sleeps, or a quicker one, can pick its own idle_wait. The default stays 2 seconds.
# Conflicts: # temporalio/contrib/streams/_handles.py # tests/contrib/streams/test_client_wait.py
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR turns
notify_on_appendon by default and lets a client read sleep on the stream's notifier while the stream is idle. It addsStreamHandle.closeandStreamStorePlugin.close_stream, and a Worker flushes its pending notifications when it stops.Why?
A sleeping reader wakes only on a notification or the 5 minute recheck, so notifications have to be on unless a process has no sleeping reader.
How did you test it?
Link to a test plan if any -