Repository navigation
Conversation
This was referenced Oct 18, 2026
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml # temporalio/bridge/sdk-core
kj1 now reads old JSON Histories with no attachments key. Nothing generated changes.
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml # temporalio/bridge/proto/streams/streams_pb2.py
# Conflicts: # temporalio/api/stream/v1/__init__.py # temporalio/api/stream/v1/message_pb2.py # temporalio/api/stream/v1/message_pb2.pyi # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml # temporalio/bridge/proto/streams/__init__.py # temporalio/bridge/proto/streams/streams_pb2.py # temporalio/bridge/proto/streams/streams_pb2.pyi # temporalio/bridge/proto/streams/v1/message_pb2.py # temporalio/bridge/proto/streams/v1/message_pb2.pyi # temporalio/bridge/streams_generated.py
moetemp
changed the base branch from
moe/brook/v2/h10-sdk-streams
to
moe/brook/v2/h11-links
October 19, 2026 04:50
This layer's crate needs hlen, sadd and smembers and offers retention holds, so the docs say so here.
Each failure kind of this layer's crate must map to its own error.
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
The Jetty and Bridge layers pin a crate head without the withdrawn segment rule, and the crate's own follow tests cover it.
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR pins the sdk-streams crate and sdk-core that the Jetty layers build on, and regenerates the protos.
gen_protos.pyreads the crate'sapi_streamcopy too. There's no hand-written Python here.Why?
Every later Jetty PR needs the stream API messages and the crate that serves them. The generated code sits in one PR, so the others stay readable.
How did you test it?
Link to a test plan if any -