Repository navigation
Conversation
It comes back from the jp28 move-out commit 5e1c93d as it was, with its cases in the shared tests.
so3 brings back PostgresStoreConfig, so the stream protos regenerate.
2 of 3 tasks
2 of 3 tasks
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml # temporalio/bridge/proto/streams/streams_pb2.py
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
# Conflicts: # temporalio/bridge/Cargo.lock # temporalio/bridge/Cargo.toml
moetemp
changed the title
moetemp
changed the title
Owner
Author
|
Closed as unused. Jetty and Bridge are frozen, and the Brook v4 stack doesn't build on this PR. The branch stays, so this PR can be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR brings back the PostgreSQL store as an optional layer on top of po1. It pins sdk-streams so3 (
31874867) with thepostgresfeature. The first commit restoresPostgresStreams, its docs and its cases in the shared tests from jp28's move-out commit5e1c93d3. The next commits pin so3, regenerate the protos and keep the silent PostgreSQL producer silent under the notify default.Check the restore with
git diff 5e1c93d3^ <this head> -- temporalio/contrib/streams/postgres.py temporalio/contrib/streams/docs/postgres-guarantees.md.Why?
PostgreSQL holds a notification log and an archive hold, so it sits after po1.
How did you test it?
Link to a test plan if any -