Repository navigation
Conversation
# Conflicts: # advanced/samples/dotnet/tests/StreamServiceChecks.cs
Owner
Author
|
Closed as NOT-STREAM. Every streaming duration is in a proto-backed record, so it never goes through the JSON converter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR writes and reads a WIT
durationin a WIT-only (JSON) record in the proto3 JSON form, such as"1.5s", in .NET and TypeScript, as Python does.TimeSpanorTimeSpan?property of such a model gets aJsonConverterfor the proto3 form.Why?
.NET wrote
"00:00:01.5000000", and TypeScript wrote whatever the caller gave, so the languages couldn't read each other's durations.How did you test it?
The
stream-service.NET and TypeScript goldens show the converters onCreateStreamRequestandReadRecordsRequest. A sample test in each language round-tripswaitand checks that the JSON text has"0.25s".Based on fork PR #65.