Repository navigation
Conversation
A fold returns a value of the caller's type, which the Stream itself is not generic in. So helper methods no longer make their resource generic, and each keeps its own type parameters.
Client and Workflow code can fold the Records into one value of their own type. The tests check that the initial value sets the type of the result on both targets.
The guide and the architecture note say that a helper method doesn't make its resource generic. Co-authored-by: Tim Conley <timothy.conley@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR lets a helper method use a type parameter that its resource doesn't have.
value-t, and the resource stays generic in its own parameters only.reduceon bothStreamclasses.Why?
A fold over a Stream gives back a value of the caller's type. Without this change,
value-tmade the wholeStreamgeneric in it.How did you test it?
cargo validatepasses. The stream tests check a typedreduce, and a unit test checks that the resource keeps only its own parameters.Link to a test plan if any -