Repository navigation
Conversation
The API's Stream WIT moved the Workflow omit mark from `append` and `close` to `read`. Workflow code writes to a Stream and closes it again, and it does not read one.
The tests bring back the Workflow append with its default Producer and check that only the client `Stream` reads. The guide's omit example now names `read`. Co-authored-by: Tim Conley <timothy.conley@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR syncs the stream sample with temporalio/api#895, where Workflow code appends to a Stream and closes it again.
@nexus.api-omit targets="workflow"moves from the resource methodsappendandclosetoread.Streamof each language hasappendandclose, and noread. The clientStreamkeeps all three.Why?
The sample WIT is a copy of the Stream WIT of the API repo, and that WIT changed. The SDKs generate their Streams API from it, so the sample should show the same shape.
How did you test it?
cargo validatepasses.Link to a test plan if any -