fix: raise a clear RuntimeError when action_scope runs outside @inject - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calling
action_scope(ctx)from a command that is not decorated with@injectfailed inside thectx.metalookup with an error that names a private key and nothing the user can act on:Verified empirically with
CliRunnerbefore the change.Change
action_scopecatchesKeyErroron thectx.meta[_COMMAND_CONTAINER_KEY]lookup only and raises:with
from None, so the traceback ends at the actionable message. Behaviour inside an@injectcommand is unchanged. The READMEaction_scopebullet notes the new error.This completes the sweep started by #47, following the guide rule in modern-python/modern-di#490: a plain package-local
RuntimeError, not aModernDIErrorsubclass.Tests
Written red first in
tests/test_commands.py:test_action_scope_without_inject_raises_clear_error: Typer app withsetup_di, command without@injectthat opensaction_scope(ctx); failed with the originalKeyError: 'modern_di_typer.command_container'before the fixAsserts
RuntimeErrormatching@inject.just lintandjust test-cipass at 100% coverage.