Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
floorsjob the org standard requires (standard.md §7), following modern-di-fastapi#56.What the job found
starlette>=1.2holds: starlette 1.2.0 passes the suite on all six interpreters.What did not hold was the test client.
test_finished_request_leaves_no_cyclic_garbageassertscollected == 0— no cyclic garbage anywhere in the process across 20 requests — and httpx2 below 2.3 leaks cycles of its own, so the assertion failed at the floors on 3.10 through 3.14 while starlette itself was blameless.Isolated by upgrading one package at a time from the floor set on 3.13: upgrading
starletteto 1.6.0 still fails, upgradingmodern-dioranyiostill fails, upgradinghttpx2alone passes. Bisected to httpx2 2.3.0 — 2.0.0, 2.1.0 and 2.2.0 fail, 2.3.0 is the first that passes. So the bound belongs on the harness, not on the shipped floor:"httpx2>=2.3",3.14t passed the whole time only because the assertion is
collected == 0 or not gil_enabled, and the free-threaded leg takes the second branch.Why the job exists
pytestresolves every dependency at its newest, so the bottom of each declared range ships unexercised. This job resolves direct dependencies at their floors, wheel-only, on every entry of the same matrixpytestuses, and runs the suite against them.--no-build: a floor reachable only by compiling an sdist is not a floor a user installing a wheel can reach.--no-install-projectis mandatory alongside it —--no-buildwould otherwise refuse to build this project too, and the tests import it from the checkout.The dev-group floors
uv sync --resolution lowest-directtreats an unbounded name in[dependency-groups]as "any version" and resolves it to that project's first-ever release. These are lower bounds on the test harness only; none of them constrainsstarlette, so the declared floor is still what the job installs. The resolved-newest path is unchanged.Verification
Run locally on all six interpreters at the floors:
starlette==1.2.0on each, 22 passed. Resolved-newest path re-checked withjust install && just lint-ci && just test-ci. Local runs are macOS/arm64; CI is the verdict on manylinux wheel coverage.