fix(deps): raise the starlette floor - #35
Merged
Merged
Conversation
The declared >=0.40 resolves to a release where the websocket close code never reaches the client. Bisected against the suite: 1.2.0 is the first release it works with. Closes #34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34.
The bug
starlette>=0.40,<2resolves to a release where the websocket close code never reaches the client:The floor
1.2.0, bisected against the suite and confirmed monotonic — 0.47.0, 1.0.0 and 1.1.0 all fail the same way, 1.2.0 passes.
modern-di>=3.1.1was checked in the same pass and is already correct.A measurement note
The test tooling matters here. Starlette 1.6 moved
TestClienttohttpx2and the dev group declares it, but starlette at the old floor callshttpx.Client(app=...), removed in httpx 0.28. Installing currenthttpxmakes every test fail withClient.__init__() got an unexpected keyword argument 'app', which looks like a floor problem and is not one. The bisect usedhttpx>=0.27,<0.28so the resolved stack could actually run.Verification
uv pip install --resolution lowest-direct .then the full suite: 22 passed on 3.10 and 3.14. Lint clean. Normal resolution: 22 passed.Nothing changes at the top of the range, so this is inert for anyone not installing at the lower bound.
Found by the org-wide lower-bound audit in modern-python/.github#107.