chore: drop the build-order task references - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the one leftover build-order reference from when the package was written as numbered tasks. A repo-wide grep for
task [0-9](case-insensitive, excluding.git/.venv) found exactly one hit.Removed
modern_di_starlette/main.py:26—# `_DIMiddleware` writes it; `inject` (Task 3) reads it back.The line carried no constraint beyond restating what the two call sites plainly do, so it was deleted rather than shortened. The line above it, which explains what the key is, is untouched.
Gates
uv run --no-sync eof-fixer . --checkuv run --no-sync ruff format --checkuv run --no-sync ruff check --no-fixuv run --no-sync ty checkuv run --no-sync pytest -q