Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
floorsjob the org standard requires (standard.md §7), following modern-di-fastapi#56, and fixes thepytestfloor it caught.What the job found
pytest>=7resolves to pytest 7.0.0, and pytest 7.0 through 7.3 do not run on Python 3.14. Their assertion rewriter readsast.Str, which 3.14 removed:Bisected: 7.0.0, 7.1.0, 7.2.0 and 7.3.0 fail on 3.14; 7.4.0 is the first that passes. Every interpreter below 3.14 is fine at 7.0.0, so the floor splits rather than rises:
The
pytestCI matrix never saw this because it resolves newest.Why the job exists
pytestresolves every dependency at its newest, so the bottom of each declared range ships unexercised. This job resolves direct dependencies at their floors, wheel-only, on every entry of the same matrixpytestuses, and runs the suite against them.--no-build: a floor reachable only by compiling an sdist is not a floor a user installing a wheel can reach.--no-install-projectis mandatory alongside it —--no-buildwould otherwise refuse to build this project too, and the tests import it from the checkout.The dev group
pytestis deliberately left unbounded in[dependency-groups]. It is a runtime dependency of this package, so a harness bound there would override the declared floor and the job would test the wrong version.pytest-covis floored because--resolution lowest-directotherwise resolves it to its first-ever release.Verification
Run locally on all six interpreters at the floors: 25 passed on each. Resolved-newest path re-checked with
just install && just lint-ci && just test-ci. Local runs are macOS/arm64; CI is the verdict on manylinux wheel coverage.