Skip to content

fix: annotate context managers with Generator for ty 0.0.85 - #69

Merged
lesnik512 merged 1 commit into
mainfrom
fix/ty-0-0-85
Oct 7, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
fix/ty-0-0-85

Conversation

@lesnik512

@lesnik512 lesnik512 commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Closes #68

ty 0.0.85 ships a typeshed that deprecates the asynccontextmanager overload for functions annotated -> AsyncIterator[T], so ty check in the scheduled run now reports a warning and fails. This annotates the lifespan manager as AsyncGenerator[None] instead.

AsyncGenerator comes from collections.abc because typing.Generator needs all three type arguments before Python 3.13.

Changes

  • modern_di_litestar/main.py: _lifespan_manager returns collections.abc.AsyncGenerator[None] instead of typing.AsyncIterator[None].

Checklist

  • Lint and format pass (ruff)
  • Type check passes (ty)
  • Tests pass and new behavior is covered
  • Build succeeds (uv build) if packaging or build config changed
  • Repo metadata stays consistent across the three surfaces (GitHub description, pyproject description, profile blurb) if this touches packaging

@lesnik512
lesnik512 merged commit a3838ee into main Oct 7, 2026
12 checks passed
@lesnik512
lesnik512 deleted the fix/ty-0-0-85 branch October 7, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduled dependency check failed

1 participant