Repository navigation
feat: support modern-di 4 - #67
Merged
Merged
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs modern-python/modern-di#579.
Summary
modern-di>=3,<5. The lower bound stays: the plugin uses no 4.0-only API.tests/dependencies.py: the request and websocket helpers tookRequest[Any, Any, Any] | None = None. modern-di 4.0 ignores the parameter default for a context-backed argument, so theNonedefault no longer means anything. They now take a barelitestar.Request/litestar.WebSocket, as the README example does, and theisinstanceasserts go away.I re-checked the code, tests, README, CONTEXT.md and the ADR for 3.x-only names (
ContainerClosedWarning,use_lock, the registries,finalizer_errors, close resetting overrides). None are used. The lifespan comment aboutContainerClosedErroralready describes 4.0 behaviour.Verification
lint-ciclean,test-ci15 passed, 100% coverage. Also 15 passed on the floors (modern-di 3.0.0, litestar 2.23.0).ty checkclean, 15 passed, 100% coverage.Stays draft until modern-di 4.0.0 is on PyPI.