fix(deps): mark the grpcio floor and raise modern-di's - #27
Merged
Merged
Conversation
grpcio ships no cp314 wheel before 1.75.1, so the declared floor resolved to an sdist that cannot build on 3.14. Marked rather than raised, since 1.48 is fine below that. modern-di >=3 resolves to 3.0.0, where the container is already closed when the servicer resolves from it; 3.1.0 is the first release that works. Closes #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
Two floors
grpcio.
>=1.48,<2resolves to 1.48.1, which ships no cp314 wheel, so on 3.14 the resolver falls through to an sdist that cannot build. 1.75.1 is the first release with a cp314 wheel. Marked rather than raised, since 1.48 is fine below 3.14.modern-di.
>=3resolves to 3.0.0, where the container is already closed when the servicer resolves from it:3.1.0 is the first release that works, bisected within the declared
>=3,<4range.A correction to the issue
The issue said the grpcio floor fails on 3.10 as well as 3.14. That was an artifact of the audit machine: grpcio 1.48.1 has no macOS arm64 wheel but does ship
cp310wheels for Linux, which is what CI runs. The 3.10 claim does not hold there, so the floor is left at 1.48 below 3.14. Verified locally at grpcio 1.53.2 (the oldest this machine can install) that the API is fine on 3.10; CI will exercise 1.48.1 itself.Verification
uv pip install --resolution lowest-direct .then the full suite: 37 passed on 3.14, and on 3.10 at grpcio 1.53.2. Lint clean. Normal resolution: 37 passed.Nothing changes at the top of the range, so this is inert for anyone not installing at the lower bound.
Found by the org-wide lower-bound audit in modern-python/.github#107.