docs(adr): compress to 2 records in the domain-modeling format - #26
Merged
Merged
Conversation
No drops and no merges: both records pass the admission test. Each is now a single paragraph, with the revisit triggers folded into the paragraph as the boundary of the decision. Numbering and slugs are unchanged, so no citation moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites
docs/adr/from 2 records (505 words) to 2 (316 words), one paragraph each, in the shapeADR-FORMAT.mdasks for. Both records survive the admission test, so nothing is dropped or mergedand the numbering is unchanged. The
**Decision:**lead-in and the**Revisit trigger:**block goaway; each trigger is folded into its paragraph, because in both cases it is the real boundary of
the decision rather than a bookkeeping note.
Evaluation
Each record was tested against the admission test: hard to reverse, surprising without context, the
result of a real trade-off.
injectdoes not rewrite the view's signaturemodern-di-celeryandmodern-di-aiogramdo the rewrite, so this is exactly the deliberate deviation someone would port over as a fix.Citations
None moved. The only citation in the repo is the
ADR-0001example indocs/agents/domain.md, plusthe two filenames in that file's directory tree; both numbers and both slugs are unchanged, so they
still resolve. The repo-wide sweep for
adr/NNNNandADR-NNNNfinds no old or dropped number.Stale claims
None. Every concrete claim was checked against the current tree and all still hold:
setup_didoesnot open, validate, or close the container it is handed;
fetch_di_containerandflask_request_providerexist under those names inmodern_di_flask/main.py;Container.validateexists in the pinned
modern-di(3.4.0, range>=3.1,<4); the supported Flask range is stillflask>=3,<4; and the wrapper still carriesfunctools.wrapswith*args, **kwargsand no__signature__. The invariant test named by the old 0002,test_inject_preserves_the_view_name_flask_derives_endpoints_from, is still intests/test_inject.py;the new paragraph keeps the
__name__rationale but drops the pointer to the test, which the testname already carries.
Gates
pytest -q tests/test_adr_citations.py: 7 passed.pytest -q(full suite): 22 passed. No directories needed external services, so none were skipped.eof-fixer . --check: clean.lychee --offline --no-progressover both ADRs,CONTEXT.mdandAGENTS.md: 2 OK, 0 errors.ruff format --check/ruff check --no-fix: skipped, no Python file is touched by this change.