fix(deps): raise the modern-di floor - #29
Merged
Merged
Conversation
The declared >=3 resolves to 3.0.0, where the container is already closed when the worker resolves from it. Bisected against the suite: 3.1.0 is the first release the integration works with. arq's own >=0.25 floor is fine. Closes #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
The bug
The issue blamed
arq>=0.25. It is not arq — pinningmodern-dito current makes the suite pass with arq still at its floor.modern-di>=3,<4resolves to 3.0.0, where the container is already closed when the worker resolves from it:The floor
3.1.0, bisected against the suite within the declared
>=3,<4range. A bisect over the full version list is misleading here — 2.28.0 also passes, so the search is not monotonic across the major boundary and only the declared range is meaningful.arq>=0.25is left alone; it was never the problem.Verification
uv pip install --resolution lowest-direct .then the full suite: 29 passed on 3.10 and 3.14. Lint clean. Normal resolution: 29 passed.Nothing changes at the top of the range, so this is inert for anyone not installing at the lower bound.
Found by the org-wide lower-bound audit in modern-python/.github#107.