fix(deps): declare pydantic's floor for 3.14 - #29
Merged
Merged
Conversation
aiogram pulls pydantic transitively, and pydantic-core ships no cp314 wheel before pydantic 2.12, so the lowest declared combination had no installable pydantic on 3.14. Declared directly rather than reached sideways by raising aiogram, which names the actual constraint. Closes #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
The bug
aiogram>=3.2,<4resolves to 3.2, which pins an old pydantic whosepydantic-coreships no cp314 wheel, so the install fails on 3.14:The fix
pydantic>=2.12; python_version >= '3.14', declared directly rather than reached sideways by raising the aiogram floor. pydantic is not imported here, but it is the actual constraint, and naming it keeps the aiogram range honest — the same shapelite-bootstrapandfaststream-outboxalready use.Verification
uv pip install --resolution lowest-direct .then the full suite: 27 passed on 3.10 and 3.14. Lint clean. Normal resolution: 27 passed.Nothing changes at the top of the range, so this is inert for anyone not installing at the lower bound.
Found by the org-wide lower-bound audit in modern-python/.github#107.