Skip to content

test: patch params_storage on the class so the teardown test survives faststream 0.7.7's __slots__ #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Sep 25, 2026
Merged

test: patch params_storage on the class so the teardown test survives faststream 0.7.7's __slots__ #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions tests/test_faststream_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,26 +302,18 @@ async def test_faststream_prometheus_is_skipped_without_middleware_or_registry(b
bootstrapper.teardown()


def test_faststream_logging_teardown_runs_super_when_broker_write_raises(broker: RedisBroker) -> None:
def test_faststream_logging_teardown_runs_super_when_broker_write_raises(
broker: RedisBroker, monkeypatch: pytest.MonkeyPatch
) -> None:
bootstrap_config = build_faststream_config(broker=broker)
instrument = FastStreamLoggingInstrument(bootstrap_config=bootstrap_config)
instrument.bootstrap()

# Make broker.config.logger.params_storage raise on write by promoting the instance to a
# subclass that shadows params_storage with a property whose setter always raises.
logger_state = broker.config.logger

class _BrokenLoggerState(type(logger_state)): # ty: ignore[unsupported-base]
@property # type: ignore[override]
def params_storage(self) -> object: # pragma: no cover
return None

@params_storage.setter
def params_storage(self, _value: object) -> None:
msg = "broker write boom"
raise RuntimeError(msg)
def _raise_on_write(_self: object, _value: object) -> None:
msg = "broker write boom"
raise RuntimeError(msg)

logger_state.__class__ = _BrokenLoggerState
monkeypatch.setattr(type(broker.config.logger), "params_storage", property(fset=_raise_on_write), raising=False)

# super().teardown() still runs (LoggingInstrument's structlog reset); broker write raises last.
with pytest.raises(RuntimeError, match="broker write boom"):
Expand Down
Loading