fix(deps): cap faststream below 0.7.6 - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastStream 0.7.6 breaks this package.
tyreports 10 errors and the suite fails at runtime:SubscriberUsecase.add_tasknow returnsNone, so the timeout path insubscriber/usecase.pyraisesTypeError: object NoneType can't be used in 'await' expressionawaiting the task it spawned.faststream.asgi.factories.asyncapi.try_it_out._get_broker_registryis gone, so the TestBroker registration in__init__.pyno longer resolves.addressis now required on the publisher/subscriber usecases, andTimersSubscriberSpecificationresolves to an abstract class.The cap is a stopgap that gets
maingreen again, not the fix. Adapting to 0.7.6 and lifting the cap is separate work.Verified locally at the cap:
just lint-ciclean, 161 tests pass at 100% coverage.