Conversation
The comment credited the 0.13.2 -> 0.7.6 breakage to the declared floor. `git show 0.13.2:pyproject.toml` says `faststream>=0.7.1,<0.8`, and 0.7.6 is inside that range: the break came from resolving newest, which `pytest` already covers, and a leg resolving `lowest-direct` would have installed 0.7.1 and passed. The floor was raised to 0.7.6 in #182 because adapting to the new API dropped support for 0.7.1-0.7.5, not because the floor was untested. Replaced with this repo's own floor failure, the one #186 fixed: `sqlalchemy[asyncio]>=2.0` installs on 3.13 and then fails at import, because SQLAlchemy's TypingOnly check rejects the `__firstlineno__` and `__static_attributes__` attributes 3.13 added. Nothing but this leg installs that version. Comment only; no job behaviour changes.
Benchmark gate✅ gate passed
Gated (fails the build): |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line of comment in
_checks.yml. No job behaviour changes.The claim that was wrong
That incident is real, but it is not an argument for this job — it is the opposite of one.
0.7.6 is inside
>=0.7.1,<0.8. The break came in at the top of the range, from resolving newest, whichpytestandscheduled-dep-checkalready do — and a leg resolvinglowest-directwould have installed 0.7.1, the version that was working, and passed. This job would not have caught it.The floor moved to 0.7.6 in #182, and reading that commit confirms the direction: adapting to the new
TestBroker.__init_subclass__(broker=...)hook madeimport faststream_outboxfail on 0.7.5, so the floor was raised to say so. The floor followed the code; it was not caught going stale.Leaving it in place is worse than a stray inaccuracy — it is the comment a reader consults to decide whether the job is worth its matrix, and it argues for the job with an incident the job is blind to.
The replacement
This repo's own floor failure, the one #186 fixed:
Verified by running it — 3.13, wheel-only:
It is a better example than the one it replaces on three counts. It is this repo's, not a sibling's. It is the failure mode only this leg reaches —
pytestresolves SQLAlchemy 2.0.4x and never sees it. And it installs cleanly and then fails, so it is not covered by a wheel-coverage check either; you have to resolve low and actually run something.The two surrounding sentences are untouched, and the comment stays the same length.
Verification
just install && just lint-ci && just test-ciagainst a local postgres 17: clean, 624 passed, 100% coverage. The workflow still parses and thelowestjob's matrix is unchanged (3.11–3.14).Noticed nearby, not fixed here
Two things I left alone so this stays a one-line diff, both worth a separate look:
pyproject.tomlcarries# (2.8.0 carries pydantic-core 2.20.0, which has none)about cp313 wheels, from ci: resolve the floors wheel-only; fix the 3.13 pydantic floor #190. pydantic-core 2.20.0 ships 11 cp313 wheels — every platform exceptmacosx_11_0_arm64, which 2.20.1 adds. The>=2.8.1floor is right, but for a macOS-arm64 reason, and onubuntu-latest2.8.0 would have installed. The comment overstates it.docs/tutorials/first-outbox-app.md:43still shows+ faststream==0.7.1in sample install output; the floor has been>=0.7.6since chore(deps): adapt to faststream 0.7.6 and raise its floor #182.