ci: rename the lowest job to floors and skip it on scheduled runs - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips the
floorsjob on scheduled runs withif: github.event_name != 'schedule'. The job still gates every pull request and every push to main.It also renames the job from
lowesttofloors, the name the standard uses (modern-python/.github#111).Why, per section 7 of the standard (modern-python/.github#113): direct dependencies sit at their declared floors, which don't change between runs. So a scheduled floors run can only catch transitive drift, and the scheduled
pytestalready covers newest-version breakage. A reusable workflow sees its caller'sgithubcontext, so the callers don't change.