fix(deps): give the three unbounded dependencies a lower bound - #53
Merged
Merged
Conversation
tenacity, sqlalchemy and asyncpg were declared as bare names, so the range admitted every release ever published and sqlalchemy resolved to 0.1.0 from 2006, which does not build. Floors bisected against the suite. sqlalchemy and asyncpg are marked per interpreter: sqlalchemy below 2.0.31 fails its own TypingOnly check at import on 3.13+, and asyncpg ships no cp313 wheel before 0.30 or cp314 wheel before 0.31. Closes #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52.
tenacity,sqlalchemy[asyncio]andasyncpgwere each declared as a bare name, so the declared range admitted every release ever published. SQLAlchemy resolved to 0.1.0, released in 2006:The package did not install at its own declared minimum on any supported Python.
The floors
Each bisected against the suite, not guessed:
>=8.4.1>=2.0.18, marked>=2.0.31on 3.13+>=0.28, marked>=0.30on 3.13 and>=0.31on 3.14+Two need marking per interpreter, both found by verifying the bisected floors on every supported Python rather than only the oldest:
TypingOnlycheck at import on 3.13+, against the__static_attributes__and__firstlineno__attributes Python 3.13 added.requires-python >=3.8on every release but ships no cp313 wheel before 0.30 and no cp314 wheel before 0.31, so a resolver picks an sdist that cannot build rather than reporting a conflict.Marked rather than raised outright, since 2.0.18 and 0.28 are genuinely fine on 3.11 and 3.12. Same shape as modern-python/faststream-outbox#186.
Verification
uv pip install --resolution lowest-direct .then the full suite against Postgres 17:just lint-ciclean. Normal resolution: 40 passed.Nothing changes at the top of the range, so this is inert for anyone not installing at the lower bound.