fix(extensions): reject non-callable VCS operation watch hooks - #1080
Open
edenbuilds wants to merge 1 commit into
Open
fix(extensions): reject non-callable VCS operation watch hooks#1080edenbuilds wants to merge 1 commit into
edenbuilds wants to merge 1 commit into
Conversation
registerVcsAdapter validated that an operation's `load` field is
callable but let `watchSignature` and `watchPlan` through unchecked.
A truthy non-function value (e.g. a typo'd string) passed the
`watchSignature && {...}` spread guard in toInternalVcsOperation and
was wrapped, so calling it threw a TypeError only once watch planning
invoked it — well after registration.
Require both optional hooks to be absent or callable before an
operation is accepted, matching the existing drop-on-`load` behavior.
Fixes modem-dev#763
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@edenbuilds is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
PR author is not in the allowed authors list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerVcsAdaptervalidates that an operation'sloadfield is callable, but not the optionalwatchSignature/watchPlanhooks. An untyped extension can register:Registration currently accepts this. The
watchSignature && {...}spread guard intoInternalVcsOperationtreats any truthy value as present, wraps it, and the resultingTypeErroronly surfaces once watch planning invokes the hook — well after registration.Fix
toInternalVcsAdapternow requireswatchSignatureandwatchPlanto be absent or callable before accepting an operation, matching the existing behavior for a non-callableload(the whole operation entry is dropped, so lookups report "not supported" instead of failing mid-review).Test plan
an operation with a non-callable watch hook is dropped, not wrappedtopublicApiRobustness.test.ts, mirroring the existingloadcoverage.main(TypeError path) and passes with the fix.bun test packages/hunk/src/extensions/runExtension.test.ts— 51 pass, 0 fail.bun run typecheck,oxfmt --check,oxlint --deny-warningsall clean on the changed files.Fixes #763