Repository navigation
fix(web): group SLO controls under routing - #49
Merged
Merged
Conversation
imneov
force-pushed
the
fix/slo-routing-section
branch
from
October 10, 2026 01:14
93c645e to
1aa6b8a
Compare
Keep the deployment form aligned with Swiss by removing the separate SLO and monitoring section. Route-related controls now stay together, while ServiceMonitor remains an advanced setting.
imneov
force-pushed
the
fix/slo-routing-section
branch
from
October 10, 2026 01:23
1aa6b8a to
41af5e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
The deployment form currently presents a separate “SLO and monitoring” section even though every control in that panel belongs with routing configuration. This removes the section and moves SLO, TTFT/TPS limits, adaptive concurrency, Monitor, and ServiceMonitor into Routing. Advanced returns to containing only the existing values override.
The submitted deployment plan is unchanged; only the UI grouping and documentation move.
Which issue(s) this PR fixes
None.
How it was tested
npm test: 26 files, 216 tests passednpm run typechecknpm run buildgofmt -l .: emptygo vet ./...go test ./...Checks
go test ./...andgofmt -l .is emptynpm run typecheck && npm test && npm run buildinweb/Notes for reviewers
Start with
web/src/modules/inferences/components/DeployForm.tsx. TheSECTIONSchange removes the obsolete navigation item and accordion; the section test locks the resulting four-section structure.Actual UI verification remains pending because the designated environment does not run this repository.
Release note