Skip to content

Feat/bug fix#920

Merged
alcholiclg merged 13 commits into
modelscope:mainfrom
alcholiclg:feat/bug_fix
Jul 8, 2026
Merged

Feat/bug fix#920
alcholiclg merged 13 commits into
modelscope:mainfrom
alcholiclg:feat/bug_fix

Conversation

@alcholiclg

@alcholiclg alcholiclg commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Change Summary

  • bug fix for webui
  • support for tui (beta version)

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
  • Documentation reflects the changes where applicable

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a data-driven provider layer that replaces hard-coded LLM service mappings with a declarative spec registry and transport system. It also adds a lightweight Terminal UI (TUI) application and consolidates framework-internal directories under a single .ms_agent/ namespace to keep the working directory clean. The review feedback highlights several critical issues: the permission handler selection needs to support the default restricted mode; the OpenAI-compatible transport must guard continuation attempts to avoid 400 errors on strict APIs; the workspace zip download requires symlink resolution to prevent path traversal; the argument parser should ignore the standard -- separator; and log directory creation needs exception handling to prevent startup crashes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ms_agent/agent/llm_agent.py Outdated
Comment thread ms_agent/llm/transport/openai_compat.py Outdated
Comment thread ms_agent/llm/transport/openai_compat.py Outdated
Comment thread ms_agent/project/workspace.py
Comment thread ms_agent/config/config.py Outdated
Comment thread ms_agent/utils/logger.py Outdated
@alcholiclg alcholiclg merged commit a51e450 into modelscope:main Jul 8, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants