fix(core): clear consumed stdio read buffer#2539
Closed
sidsri14 wants to merge 1 commit into
Closed
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
Closing for now. I want to complete broader local validation and get explicit approval before keeping this PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadBuffer's internal buffer whenreadMessage()consumes through the final byte.Fixes #2536.
Verification
npx pnpm --filter @modelcontextprotocol/core-internal test -- test/shared/stdio.test.tsnpx pnpm --filter @modelcontextprotocol/core-internal typechecknpx prettier --check packages/core-internal/src/shared/stdio.ts packages/core-internal/test/shared/stdio.test.tsnpx eslint src/shared/stdio.tsfrompackages/core-internalNote:
pnpm --filter @modelcontextprotocol/core-internal lintcurrently fails on repo-wide Prettier checks for many pre-existing files in my Windows checkout, so I ran Prettier/eslint on the touched files directly.