Suppress KeyboardInterrupt tracebacks from MCPServer.run#2778
Open
koriyoshi2041 wants to merge 1 commit into
Open
Suppress KeyboardInterrupt tracebacks from MCPServer.run#2778koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
Author
|
CI triage note: the failing 3.14 lowest-direct jobs are failing in
The locked 3.14 Ubuntu job and the other Python versions are passing, and this PR only touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Interrupting an
MCPServer.run(transport="stdio")process with Ctrl-C can surface the full AnyIO/asyncio cancellation traceback even though the server is just shutting down. Issue #2663 is marked ready for work and points to the syncrun()boundary as the narrow fix point.Fix
Wrap the transport dispatch in
MCPServer.run()with aKeyboardInterruptguard so user interrupts return cleanly. Other exceptions still propagate.Tests
uv run pytest tests/server/mcpserver/test_server.pyuv run ruff format --check src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_server.pyuv run ruff check src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_server.pyuv run pyright src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_server.pygit diff --checkRisk
Low. The guard is only at the synchronous
run()entry point and only handlesKeyboardInterrupt; ordinary startup/runtime exceptions are still re-raised.Fixes #2663