Add cancel control for task polling#1729
Open
HarperZ9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a cancel control for tool calls that are running as MCP tasks and currently being polled from the Tools tab.
Root cause
The app already exposed
tasks/cancelthrough the Tasks tab, but a user who launched a tool as a task from the Tools tab only saw the disabledPolling Task...button. The active polling task ID was not stored in a way that Tools could cancel, and the polling loop could continue intotasks/getafter a user wanted to stop it.Changes
App.pollingTaskIdandcancelTaskPollingintoToolsTab.Cancel Taskbutton while a tool task is actively polling.tasks/get/tasks/resultresponses overwriting the cancelled state.Closes #1039.
Validation
npm.cmd test -- --runTestsByPath src/__tests__/App.taskPolling.test.tsx --runInBandnpm.cmd run build-clientnpm.cmd run lintnpx.cmd prettier --check client/src/App.tsx client/src/components/ToolsTab.tsx client/src/__tests__/App.taskPolling.test.tsxgit diff --check