Repository navigation
Publish Skills schemas and validate specification examples in CI - #166
Conversation
|
@codex review Please review the full PR at 6071129, especially schema conversion correctness, inherited base constraints, and false-success paths in the CI checks. Self-review fixes preserve literal/property names during conversion and validate examples before writing artifacts. Local schema checks pass (34 tests, 16 documented examples). |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60711295f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the completed resource-read validation finding in 6c32371. After validating the response envelope, the example checker now explicitly validates Validation: eight negative regression cases reproduced the bypass before the fix; Node 22 Please re-review the latest commit, including the success-branch selection and regression coverage. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@olaservo could you please approve the pending GitHub Actions CI run for this fork PR at Local validation on Node 22 passed all 43 schema tests and 16 published examples; the documentation build also passed. Codex re-review of this head completed with no findings: #166 (comment) This is a request to authorize CI execution only; I'm not requesting a code review yet. Thank you! |
|
Hi @anencore94 I just approved CI to run. |
|
Is there any chance to get this one in? It would help out for validation! |
|
@XVincentX Could you available to review this PR @olaservo ? |
|
I do not believe I have the necessary privileges to merge this |
Record why the schema directory and $id use the lifecycle stage, and that the $id is not a fixed reference across Beta revisions. Unwrap the README and decision-log additions to one line per paragraph, as the rest of both files. Select the list and get results in the tests by method, and import from schema.mjs once. Normalize CRLF before comparing schema.json. The check failed on a Windows checkout with core.autocrlf=true. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
olaservo
left a comment
There was a problem hiding this comment.
Thanks for this, and for the patience! I reviewed it against the pinned upstream commit and the core spec's generator settings, and both match.
I pushed two commits to your branch before merging:
e6b9ea7:
README.mdanddocs/decisions.md: record why the directory and$idusebeta. SEP-3392 requires dated revisions only at Stable, and a Beta extension can ship more than one revision against the same core revision. The$idnames the current Beta revision, so consumers that need fixed content pin to a commit.README.mdanddocs/decisions.md: unwrap the additions to one line per paragraph, as the rest of both files.docs/decisions.md: add this PR and SEP-3392 to the entry's references.scripts/schema.test.mjs: select the list and get results by method, and import fromschema.mjsonce.scripts/schema.mjs: normalize CRLF before comparingschema.json. The check failed on a Windows checkout withcore.autocrlf=true.
e18b0a2:
docs/decisions.md: set the 2026-11-02 entry toAccepted.
|
Thanks @olaservo - would it be possible to also cut a GitHub release? That helps people that want to download the file for their own validation purposes - thanks! |
Hi @XVincentX , I published v0.1.0 as a pre-release with |
|
That will absolutely do - thanks |
Closes #158.
The released Skills page defines wire types in prose, so an implementation can omit required cache attributes while its own tests still pass. This adds consumable TypeScript and JSON Schema plus a CI job that checks the artifact, all 13 documented declarations, and all 16 JSON message examples.
schema/beta/schema.tsmirrors the released interfaces and imports a pinned, vendored copy of the2026-07-28base types. JSON generation uses the core specification'stypescript-json-schemagenerator and integer-number convention; generation and validation are offline after dependency installation.ttlMsorcacheScope. Tests also cover inherited request metadata, cache constraints, dynamic manifests, type/JSDoc drift, and malformed or unmapped examples.resultType: "complete"requirement.Validation (local): Initial validation on Node 22.23.4; follow-up self-review checks on Node 23.11.0,
npm run check:schema(34 tests and all 16 examples pass);npm run docs:build; production preview HTTP smoke check; pinned base re-fetch produces identical artifacts; a deliberately stale JSON artifact is rejected without being rewritten;git diff --check. GitHub CI has not executed the jobs yet: run 41511523641 isaction_required, with no job results available.The schema layout and identifier are proposed in the decision log. The
$iddoes not itself deploy a hosting endpoint. Automated code review is requested before further human review requests.AI assistance: Codex assisted with implementation, local validation, and this description.