Skip to content

Update to convention v1#23

Merged
irm-codebase merged 4 commits into
mainfrom
chore/template-update
Jul 1, 2026
Merged

Update to convention v1#23
irm-codebase merged 4 commits into
mainfrom
chore/template-update

Conversation

@irm-codebase

@irm-codebase irm-codebase commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

After this is merged, the module can have its first release!

Summary of changes in this pull request

  • Pin gregor to v0.1.0
  • Use convention v1
  • Improved docs with some examples.

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

@jnnr jnnr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few comments, mainly on the documentation of config options.

Comment thread .github/workflows/release.yml Outdated
Comment thread config/README.md
Comment thread config/README.md Outdated
Comment thread config/README.md Outdated
@irm-codebase

Copy link
Copy Markdown
Collaborator Author

@jnnr fixed!
Ok to merge?

@irm-codebase irm-codebase requested a review from jnnr June 30, 2026 11:42
@irm-codebase irm-codebase merged commit bf36d05 into main Jul 1, 2026
4 checks passed
@irm-codebase irm-codebase deleted the chore/template-update branch July 1, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants