Skip to content

Feature update template#3

Merged
jnnr merged 9 commits into
mainfrom
feature-update-template
Jul 1, 2026
Merged

Feature update template#3
jnnr merged 9 commits into
mainfrom
feature-update-template

Conversation

@jnnr

@jnnr jnnr commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Fixes #

Summary of changes in this pull request

  • Update to the newest template of data-module-template
  • Reconcile merge conflicts.
  • Reduce number of envs, keep only one module.yaml
  • Define dependencies in pixi.toml, export env and pin files.

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

@jnnr jnnr requested a review from irm-codebase June 30, 2026 19:22

@irm-codebase irm-codebase left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

However... Seems like pixi pinning strategy is missing for some reason...
I still have not figured out why it is not detected well on your machine.

We should go over it before merging, just in case there is a real issue with the template.

Comment thread pixi.toml Outdated
Comment on lines +25 to +34
[feature.module.dependencies]
curl = "=8.9.1"
pycountry = "=24.6.1"
pyarrow = "=17.0.0"
fastparquet = "=2026.5.0"
pydantic = "=2.13.4"
entsoe-py = "=0.8.0"
dask = "=2026.6.0"
numpy = "=1.26.4"
gregor = "=0.1.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not obligatory, but keep in mind that you can change the "=0.1.0" too ">=0.1.0" after the first import if you wish to allow for easy future updates to the module environment.

The conda pins should protect users in any case.

@irm-codebase irm-codebase self-requested a review July 1, 2026 08:24
@jnnr jnnr merged commit b70050f into main Jul 1, 2026
6 of 7 checks passed
@jnnr jnnr deleted the feature-update-template branch July 1, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants